fix a few issues around exported libraries

- Fix a few issues around exported libraries
- Add support for html imports without adding an html dependency by running from all libraries in the mirror system in reverse order instead of just the root one.

R=sigmund@google.com

Committed: https://github.com/dart-lang/initialize/commit/d5dc20191345a0cecd6302225118815af1afeee3

[jakemac, 2015-03-03 18:09:04]

jakemac@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2015-03-03 20:19:25]

lgtm

https://codereview.chromium.org/973073003/diff/1/lib/transformer.dart
File lib/transformer.dart (right):

https://codereview.chromium.org/973073003/diff/1/lib/transformer.dart#newcode241
lib/transformer.dart:241: // Visit all our imports.
revert just this one comment? (imports => dependencies)

https://codereview.chromium.org/973073003/diff/1/lib/transformer.dart#newcode421
lib/transformer.dart:421: if (element is ExportElement) return
element.exportedLibrary;
do we care also about Part directives?

I think not yet, but maybe add a TODO? (we don't support annotations on the
`part-of` directive, but we could one day)

[jakemac, 2015-03-04 15:55:42]

Updated this with the support for html imports as we talked about yesterday

https://codereview.chromium.org/973073003/diff/1/lib/transformer.dart
File lib/transformer.dart (right):

https://codereview.chromium.org/973073003/diff/1/lib/transformer.dart#newcode241
lib/transformer.dart:241: // Visit all our imports.
On 2015/03/03 20:19:25, Siggi Cherem (dart-lang) wrote:
> revert just this one comment? (imports => dependencies)

Done.

https://codereview.chromium.org/973073003/diff/1/lib/transformer.dart#newcode421
lib/transformer.dart:421: if (element is ExportElement) return
element.exportedLibrary;
On 2015/03/03 20:19:25, Siggi Cherem (dart-lang) wrote:
> do we care also about Part directives?
> 
> I think not yet, but maybe add a TODO? (we don't support annotations on the
> `part-of` directive, but we could one day)

Done.

[Siggi Cherem (dart-lang), 2015-03-04 16:43:52]

yay! lgtm

https://codereview.chromium.org/973073003/diff/40001/lib/src/mirror_loader.dart
File lib/src/mirror_loader.dart (right):

https://codereview.chromium.org/973073003/diff/40001/lib/src/mirror_loader.da...
lib/src/mirror_loader.dart:57: libToRun.uri.toString().endsWith('\$trampoline'))
{
maybe it's enough to do 

  libToRun.uri.path.endsWith...

and avoid calling toString()? if not, it would be nice to switch:

  libToRun.uri.toString()

    to

  ${libtoRun.uri}'

[jakemac, 2015-03-04 16:49:49]

https://codereview.chromium.org/973073003/diff/40001/lib/src/mirror_loader.dart
File lib/src/mirror_loader.dart (right):

https://codereview.chromium.org/973073003/diff/40001/lib/src/mirror_loader.da...
lib/src/mirror_loader.dart:57: libToRun.uri.toString().endsWith('\$trampoline'))
{
On 2015/03/04 16:43:52, Siggi Cherem (dart-lang) wrote:
> maybe it's enough to do 
> 
>   libToRun.uri.path.endsWith...
> 
> and avoid calling toString()? if not, it would be nice to switch:
> 
>   libToRun.uri.toString()
> 
>     to
> 
>   ${libtoRun.uri}'
> 

good point switched to .path

[jakemac, 2015-03-04 16:52:58]

Committed patchset #4 (id:60001) manually as
d5dc20191345a0cecd6302225118815af1afeee3 (presubmit successful).