Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 971833002: Correct typing of LinkedHashSet.add. Add unit test. (Closed)

Created:
5 years, 9 months ago by koda
Modified:
5 years, 9 months ago
Reviewers:
skybrian
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Correct typing of LinkedHashSet.add. Add unit test. BUG=dart:22605 R=skybrian@google.com Committed: https://code.google.com/p/dart/source/detail?r=44155

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -2 lines) Patch
M runtime/lib/compact_hash.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A tests/corelib/hash_set_type_check_test.dart View 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
koda
5 years, 9 months ago (2015-03-02 18:36:36 UTC) #1
skybrian
lgtm
5 years, 9 months ago (2015-03-02 23:43:46 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 9 months ago (2015-03-02 23:47:41 UTC) #5
koda
5 years, 9 months ago (2015-03-03 00:44:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r44155 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698