Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 971203002: Don't allow to extract a closure as a getter. (Closed)

Created:
5 years, 9 months ago by scheglov
Modified:
5 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't allow to extract a closure as a getter. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44176

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -3 lines) Patch
M pkg/analysis_server/lib/src/services/refactoring/extract_method.dart View 4 chunks +17 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_method_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 9 months ago (2015-03-03 05:25:28 UTC) #1
Brian Wilkerson
LGTM
5 years, 9 months ago (2015-03-03 14:46:54 UTC) #2
scheglov
5 years, 9 months ago (2015-03-03 16:15:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44176 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698