Don't set a propagate type if the variable has already the same static type.

Don't set a propagate type if the variable has already the same static type.

This fixes displaying both "Static type" and "Propagated type" sections in UI.

Maybe also some performance improvement because of avoiding resolving propagated elements.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=44184

[Brian Wilkerson, 2015-03-03 14:53:49]

LGTM

https://codereview.chromium.org/971193003/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/element.dart (right):

https://codereview.chromium.org/971193003/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/element.dart:6342: if (identical(object, this)) {
I'm not sure why this logic needs to be duplicated (both here and in
internalEquals).

https://codereview.chromium.org/971193003/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/static_type_analyzer.dart (right):

https://codereview.chromium.org/971193003/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/static_type_analyzer.dart:1288: if
(_isReallyMoreSpecificThan(rightType, element.type)) {
Shouldn't this test be moved into _recordPropagatedType?

[scheglov, 2015-03-03 15:02:17]

https://codereview.chromium.org/971193003/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/element.dart (right):

https://codereview.chromium.org/971193003/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/element.dart:6342: if (identical(object, this)) {
On 2015/03/03 14:53:49, Brian Wilkerson wrote:
> I'm not sure why this logic needs to be duplicated (both here and in
> internalEquals).

Here we have a chance to check quickly without creating a HashSet instance, e.g.
"int == int".
In internalEquals we short circuit equals for type used in other types, e.g.
"int" in "List<int> == List<int>"

https://codereview.chromium.org/971193003/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/static_type_analyzer.dart (right):

https://codereview.chromium.org/971193003/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/static_type_analyzer.dart:1288: if
(_isReallyMoreSpecificThan(rightType, element.type)) {
On 2015/03/03 14:53:49, Brian Wilkerson wrote:
> Shouldn't this test be moved into _recordPropagatedType?

Maybe.
It takes Expression, so we would need to add the "staticType" parameter.
I will review all the other places in the following CL.

[scheglov, 2015-03-03 17:39:12]

Committed patchset #1 (id:1) manually as 44184 (presubmit successful).