Issue 971123002: Add a variant on ConsoleReporter that doesn't import dart:io.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 971123002: Add a variant on ConsoleReporter that doesn't import dart:io. (Closed)

Created:
5 years, 9 months ago by nweiz

Modified:
5 years, 9 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/unittest@master

Target Ref:
refs/heads/master

Visibility:
Public.

Add a variant on ConsoleReporter that doesn't import dart:io. This is necessary to avoid an IO dependency in lib/unittest.dart, which would prevent browser tests from running. R=kevmoo@google.com Committed: https://github.com/dart-lang/unittest/commit/4dddf1146ff6e207d2e299dd5a375f5110f05bc1

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -531 lines)			Patch
M	bin/unittest.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
D	lib/src/runner/console_reporter.dart	View	1 chunk	+0 lines, -235 lines	0 comments	Download
A +	lib/src/runner/reporter/compact.dart	View	6 chunks	+10 lines, -51 lines	0 comments	Download
A +	lib/src/runner/reporter/no_io_compact.dart	View	7 chunks	+18 lines, -63 lines	0 comments	Download
M	lib/src/utils.dart	View	1 chunk	+41 lines, -0 lines	0 comments	Download
M	lib/unittest.dart	View	2 chunks	+2 lines, -3 lines	0 comments	Download
A +	test/compact_reporter_test.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	test/console_reporter_test.dart	View	1 chunk	+0 lines, -178 lines	0 comments	Download

Total messages: 6 (2 generated)

Bob Nystrom

On 2015/03/03 00:49:17, nweiz wrote: Kevin's back! Punting this over to him. :) - bob

5 years, 9 months ago (2015-03-03 16:54:51 UTC) #4

nweiz

5 years, 9 months ago (2015-03-03 20:05:23 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4dddf1146ff6e207d2e299dd5a375f5110f05bc1 (presubmit successful).