Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 971103002: Add BrowserManager and IframeTest for communicating with browser tests. (Closed)

Created:
5 years, 9 months ago by nweiz
Modified:
5 years, 9 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/unittest@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add BrowserManager and IframeTest for communicating with browser tests. See #5 R=kevmoo@google.com Committed: https://github.com/dart-lang/unittest/commit/c5e657750aac9cd2e344858c679c23d693cc7b39

Patch Set 1 #

Patch Set 2 : Fix errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -24 lines) Patch
A lib/src/runner/browser/browser_manager.dart View 1 1 chunk +68 lines, -0 lines 0 comments Download
A + lib/src/runner/browser/iframe_test.dart View 2 chunks +19 lines, -24 lines 0 comments Download
M lib/src/utils.dart View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
nweiz
5 years, 9 months ago (2015-03-02 23:02:23 UTC) #2
kevmoo
lgtm
5 years, 9 months ago (2015-03-03 21:02:03 UTC) #4
nweiz
5 years, 9 months ago (2015-03-03 21:07:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c5e657750aac9cd2e344858c679c23d693cc7b39 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698