Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 970853006: Fix reference counting bug in StatementRewriter. (Closed)

Created:
5 years, 9 months ago by asgerf
Modified:
5 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix reference counting bugs in StatementRewriter. BUG= R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=44231

Patch Set 1 #

Total comments: 1

Patch Set 2 : Consistent use of pre-decrement #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart View 1 5 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
5 years, 9 months ago (2015-03-04 10:12:47 UTC) #2
Kevin Millikin (Google)
lgtm https://codereview.chromium.org/970853006/diff/1/pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart File pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart (right): https://codereview.chromium.org/970853006/diff/1/pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart#newcode527 pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart:527: --s.variable.writeCount; I guess we should be consistent within ...
5 years, 9 months ago (2015-03-04 10:35:30 UTC) #3
asgerf
5 years, 9 months ago (2015-03-04 13:32:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 44231 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698