Issue 970153003: Mark corelib/hash_set_type_check_test as failing on everything except the VM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 970153003: Mark corelib/hash_set_type_check_test as failing on everything except the VM (Closed)

Created:
5 years, 9 months ago by karlklose

Modified:
5 years, 9 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Mark corelib/hash_set_type_check_test as failing on except the VM. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=44165

Patch Set 2 : Fix typo. #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	tests/corelib/corelib.status	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ricow1

Please extend the suppression, other than that, lgtm https://codereview.chromium.org/970153003/diff/1/tests/corelib/corelib.status File tests/corelib/corelib.status (right): https://codereview.chromium.org/970153003/diff/1/tests/corelib/corelib.status#newcode54 tests/corelib/corelib.status:54: [ ...

5 years, 9 months ago (2015-03-03 12:20:34 UTC) #2

karlklose

5 years, 9 months ago (2015-03-03 12:32:01 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:40001) manually as 44165 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 970153003: Mark corelib/hash_set_type_check_test as failing on everything except the VM (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix typo. #

Messages