Issue 969903002: More fixes in async machinery (issue 22438 and maybe more).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 969903002: More fixes in async machinery (issue 22438 and maybe more). (Closed)

Created:
5 years, 9 months ago by regis

Modified:
5 years, 9 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

More fixes in async machinery (issue 22438 and maybe more). Add a regression test. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=44153

Patch Set 2 : #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -61 lines)			Patch
M	runtime/vm/ast_transformer.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1	4 chunks	+41 lines, -59 lines	0 comments	Download
M	tests/language/language_analyzer.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/language/language_analyzer2.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/language/regress_22438_test.dart	View		1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

hausner

lgtm https://codereview.chromium.org/969903002/diff/1/tests/language/regress_22438_test.dart File tests/language/regress_22438_test.dart (right): https://codereview.chromium.org/969903002/diff/1/tests/language/regress_22438_test.dart#newcode13 tests/language/regress_22438_test.dart:13: } on MissingType catch(e) { The analyzer will ...

5 years, 9 months ago (2015-03-02 22:50:26 UTC) #3

regis

5 years, 9 months ago (2015-03-02 23:09:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as r44153 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 969903002: More fixes in async machinery (issue 22438 and maybe more). (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages