Issue 969393002: Change test to detect checked mode.

Issue 969393002: Change test to detect checked mode. (Closed)

Created:
5 years, 9 months ago by karlklose

Modified:
5 years, 9 months ago

Reviewers:
ricow1, koda

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Change test to detect checked mode. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=44167

Patch Set 2 : Add dartanalyzer suppression. #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -5 lines)			Patch
	M	tests/corelib/corelib.status	View	1	2 chunks	+1 line, -3 lines	0 comments	Download
	M	tests/corelib/hash_set_type_check_test.dart	View		2 chunks	+13 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ricow1

lgtm https://codereview.chromium.org/969393002/diff/1/tests/corelib/corelib.status File tests/corelib/corelib.status (left): https://codereview.chromium.org/969393002/diff/1/tests/corelib/corelib.status#oldcode61 tests/corelib/corelib.status:61: [ $runtime != vm ] analyzer will probably ...

5 years, 9 months ago (2015-03-03 13:19:32 UTC) #2

karlklose

https://codereview.chromium.org/969393002/diff/1/tests/corelib/corelib.status File tests/corelib/corelib.status (left): https://codereview.chromium.org/969393002/diff/1/tests/corelib/corelib.status#oldcode61 tests/corelib/corelib.status:61: [ $runtime != vm ] Yes, added a suppression ...

5 years, 9 months ago (2015-03-03 13:24:30 UTC) #5

karlklose

Committed patchset #2 (id:20001) manually as 44167 (presubmit successful).

5 years, 9 months ago (2015-03-03 13:25:17 UTC) #6

Message was sent while issue was closed.

Sorry. Thanks for fixing this!

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages