Add some async/await tests.

Add some async/await tests.

R=sgjesse@google.com, sigurdm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44368

Committed: https://code.google.com/p/dart/source/detail?r=44395

[Lasse Reichstein Nielsen, 2015-03-02 14:56:38]

lrn@google.com changed reviewers:
+ sgjesse@google.com

[Lasse Reichstein Nielsen, 2015-03-02 14:56:39]

One test is currently commented out since the syntax alone makes the VM crash.

[hausner, 2015-03-02 20:21:56]

hausner@google.com changed reviewers:
+ hausner@google.com

[hausner, 2015-03-02 20:21:56]

DBC: the await (throw...) bug has been fixed in the VM at r44142.

[Søren Gjesse, 2015-03-03 08:08:42]

LGTM

https://codereview.chromium.org/968963002/diff/1/tests/language/async_await_t...
File tests/language/async_await_test.dart (right):

https://codereview.chromium.org/968963002/diff/1/tests/language/async_await_t...
tests/language/async_await_test.dart:54: onError: (e, s) { expect(e,
equals("err")); });
Indentation.

https://codereview.chromium.org/968963002/diff/1/tests/language/async_await_t...
tests/language/async_await_test.dart:93: await x;  // Check grammar: Are
parentheses necessary?
Add test for await local without a throw.

Add test for await on an argument.

https://codereview.chromium.org/968963002/diff/1/tests/language/async_await_t...
tests/language/async_await_test.dart:114: expect(v, equals(42));  // And not a
Future with value id(42).
id(42) -> 42.

Did you intend to use id(42) above?

https://codereview.chromium.org/968963002/diff/1/tests/language/async_await_t...
tests/language/async_await_test.dart:149: expect(v, equals(0));  // 0 + 1 + ...
+ 9
Remove comment.

https://codereview.chromium.org/968963002/diff/1/tests/language/async_await_t...
tests/language/async_await_test.dart:307: });
How about for tests with continue (same for while).

https://codereview.chromium.org/968963002/diff/1/tests/language/async_await_t...
tests/language/async_await_test.dart:909: onError: (e) { expect(e,
equals("err")); });
Also checck x is 74.

https://codereview.chromium.org/968963002/diff/1/tests/language/async_await_t...
tests/language/async_await_test.dart:981: id(v) {
Maybe move this up to mkStream (or move mkStream down here).

[Lasse Reichstein Nielsen, 2015-03-03 11:22:42]

Goodie, await throw test reenabled.

https://codereview.chromium.org/968963002/diff/1/tests/language/async_await_t...
File tests/language/async_await_test.dart (right):

https://codereview.chromium.org/968963002/diff/1/tests/language/async_await_t...
tests/language/async_await_test.dart:54: onError: (e, s) { expect(e,
equals("err")); });
I made an abstraction for "throwsErr".

https://codereview.chromium.org/968963002/diff/1/tests/language/async_await_t...
tests/language/async_await_test.dart:93: await x;  // Check grammar: Are
parentheses necessary?
Ah, await of different expression types! Good idea. I will do much more with
that.

https://codereview.chromium.org/968963002/diff/1/tests/language/async_await_t...
tests/language/async_await_test.dart:114: expect(v, equals(42));  // And not a
Future with value id(42).
Nope.

https://codereview.chromium.org/968963002/diff/1/tests/language/async_await_t...
tests/language/async_await_test.dart:149: expect(v, equals(0));  // 0 + 1 + ...
+ 9
On 2015/03/03 08:08:41, Søren Gjesse wrote:
> Remove comment.

Done.

https://codereview.chromium.org/968963002/diff/1/tests/language/async_await_t...
tests/language/async_await_test.dart:307: });
Sure, why not!

https://codereview.chromium.org/968963002/diff/1/tests/language/async_await_t...
tests/language/async_await_test.dart:909: onError: (e) { expect(e,
equals("err")); });
On 2015/03/03 08:08:41, Søren Gjesse wrote:
> Also checck x is 74.

Done.

https://codereview.chromium.org/968963002/diff/1/tests/language/async_await_t...
tests/language/async_await_test.dart:981: id(v) {
Moving mkStream down. I have added many more helpers.

[Søren Gjesse, 2015-03-03 11:39:56]

https://codereview.chromium.org/968963002/diff/1/tests/language/async_await_t...
File tests/language/async_await_test.dart (right):

https://codereview.chromium.org/968963002/diff/1/tests/language/async_await_t...
tests/language/async_await_test.dart:114: expect(v, equals(42));  // And not a
Future with value id(42).
On 2015/03/03 11:22:42, Lasse Reichstein Nielsen wrote:
> Nope.

What I ment was that the comment should not have id(42) - only 42.

[Søren Gjesse, 2015-03-03 12:27:42]

lgtm

https://codereview.chromium.org/968963002/diff/20001/tests/language/async_awa...
File tests/language/async_await_test.dart (right):

https://codereview.chromium.org/968963002/diff/20001/tests/language/async_awa...
tests/language/async_await_test.dart:1261: });
Mybe also for 'else if'.

[Lasse Reichstein Nielsen, 2015-03-03 12:30:34]

+sigurdm

[Lasse Reichstein Nielsen, 2015-03-03 12:51:03]

https://codereview.chromium.org/968963002/diff/20001/tests/language/async_awa...
File tests/language/async_await_test.dart (right):

https://codereview.chromium.org/968963002/diff/20001/tests/language/async_awa...
tests/language/async_await_test.dart:1261: });
On 2015/03/03 12:27:41, Søren Gjesse wrote:
> Mybe also for 'else if'.

Done.

[sigurdm, 2015-03-03 13:24:38]

sigurdm@google.com changed reviewers:
+ sigurdm@google.com

[sigurdm, 2015-03-03 13:24:39]

DBC

These tests are worth gold!

https://codereview.chromium.org/968963002/diff/40001/tests/language/async_awa...
File tests/language/async_await_test.dart (right):

https://codereview.chromium.org/968963002/diff/40001/tests/language/async_awa...
tests/language/async_await_test.dart:1825: Future then(callback(value),
[Function onError]) {
onError should be a named argument.

[sigurdm, 2015-03-03 14:13:10]

LGTM Except some referenced getters are commented out:
topArrowGetter, topArrowGetter, instanceArrowGetter

https://codereview.chromium.org/968963002/diff/100001/tests/language/async_aw...
File tests/language/async_await_test.dart (right):

https://codereview.chromium.org/968963002/diff/100001/tests/language/async_aw...
tests/language/async_await_test.dart:1881: Future catchError(Function onError,
[bool test(error)]) => this;
Also test needs to be named parameter

[Lasse Reichstein Nielsen, 2015-03-10 12:56:49]

Committed patchset #13 (id:240001) manually as 44368 (presubmit successful).

[Lasse Reichstein Nielsen, 2015-03-11 10:16:12]

Committed patchset #14 (id:260001) manually as 44395 (presubmit successful).

[ahe, 2015-08-18 13:55:08]

ahe@google.com changed reviewers:
+ ahe@google.com

[ahe, 2015-08-18 13:55:09]

https://codereview.chromium.org/968963002/diff/260001/tests/language/async_st...
File tests/language/async_star_test.dart (right):

https://codereview.chromium.org/968963002/diff/260001/tests/language/async_st...
tests/language/async_star_test.dart:7: import "package:unittest/unittest.dart";
This means that the package unittest cannot use the language feature async*
because it is tested by unittest. If unittest was to use async*, you couldn't
know if async* is broken, because it may just be broken in such a way that
unittest would pass.

Generally, when testing feature A, one should not use something that uses
feature A (or could be using feature A).

Also, you fail to test that async*  works if not invoked by the event loop. This
is because all tests in unittest are already futures themselves.

Finally, unittest may rely on other features that aren't working as you're
working on a new compiler. This is particularly unfortunate if this new compiler
is trying to improve how features like async* are handled.