Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Issue 968913005: Revert r44240, "fix deferred_multi_app test and change test status to reflect dartium fix" (Closed)

Created:
5 years, 9 months ago by Bill Hesse
Modified:
5 years, 9 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, Jacob
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Revert r44240, "fix deferred_multi_app test and change test status to reflect dartium fix" The multi-script html tests are still not working on Dartium - they report "Only one Dart script tag allowed per document". This error message is not in the Dart repo - it must be in the Dart branch of Blink or Chromium. BUG=dartbug.com/16603 R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=44255

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tests/html/deferred_multi_app_htmltest.html View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/html.status View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Bill Hesse
5 years, 9 months ago (2015-03-05 10:08:27 UTC) #2
ricow1
lgtm
5 years, 9 months ago (2015-03-05 10:10:32 UTC) #3
Bill Hesse
5 years, 9 months ago (2015-03-05 10:14:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44255 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698