Issue 96873002: Fix ElementVisitor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 96873002: Fix ElementVisitor (Closed)

Created:
7 years ago by sigurdm

Modified:
6 years, 10 months ago

Reviewers:
ahe, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix ElementVisitor BUG= R=ahe@google.com, kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=30787

Patch Set 3 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -65 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/elements/elements.dart	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/elements/modelx.dart	View		17 chunks	+18 lines, -18 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/elements/visitor.dart	View	1	3 chunks	+7 lines, -44 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/scanner/class_element_parser.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/type_checker_test.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/96873002/diff/1/sdk/lib/_internal/compiler/implementation/elements/visitor.dart File sdk/lib/_internal/compiler/implementation/elements/visitor.dart (right): https://codereview.chromium.org/96873002/diff/1/sdk/lib/_internal/compiler/implementation/elements/visitor.dart#newcode47 sdk/lib/_internal/compiler/implementation/elements/visitor.dart:47: R visitPartialClassElement(PartialClassElement e) { Not sure you want ...

7 years ago (2013-11-29 12:37:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r30787 (presubmit successful).

Expand Messages | Collapse Messages

Issue 96873002: Fix ElementVisitor (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages