Issue 968613002: Fixed tests for DOMPoint support for dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 968613002: Fixed tests for DOMPoint support for dart2js. (Closed)

Created:
5 years, 9 months ago by terry

Modified:
5 years, 9 months ago

Reviewers:
vsm, Alan Knight, karlklose, siva

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fixed tests for DOMPoint support for dart2js. TBR=asiva@google.com,vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=44115

Patch Set 1 #

Patch Set 2 : Fixed css_test to run on all platforms. #

Total comments: 1

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -14 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	tests/html/css_test.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/html/html.status	View	1	2 chunks	+0 lines, -5 lines	1 comment	Download
M	tools/dom/idl/dart/dart.idl	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Window.darttemplate	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

terry

Committed patchset #2 (id:20001) manually as 44115 (presubmit successful).

5 years, 9 months ago (2015-03-01 18:02:05 UTC) #3

karlklose

5 years, 9 months ago (2015-03-02 08:56:22 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/968613002/diff/20001/tests/html/html.status
File tests/html/html.status (left):

https://codereview.chromium.org/968613002/diff/20001/tests/html/html.status#o...
tests/html/html.status:365: [ $compiler == dart2js && ($runtime == chrome ||
$runtime == drt) && ($system == windows || $system == linux)]
These tests still fail, I changed it back in
https://codereview.chromium.org/968133002/.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages