Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 968283003: Static SPPM-n1 model for Dart Core API usage (Closed)

Created:
5 years, 9 months ago by lukechurch
Modified:
5 years, 9 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Static SPPM-n1 model for Dart Core API usage R=danrubel@google.com Committed: https://code.google.com/p/dart/source/detail?r=44158

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+428 lines, -16 lines) Patch
M pkg/analysis_server/lib/src/services/completion/common_usage_computer.dart View 1 chunk +1 line, -16 lines 0 comments Download
A pkg/analysis_server/lib/src/services/completion/common_usage_generated.dart View 1 1 chunk +427 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
lukechurch
5 years, 9 months ago (2015-03-03 01:10:00 UTC) #2
danrubel
LGTM https://codereview.chromium.org/968283003/diff/1/pkg/analysis_server/lib/src/services/completion/common_usage_generated.dart File pkg/analysis_server/lib/src/services/completion/common_usage_generated.dart (right): https://codereview.chromium.org/968283003/diff/1/pkg/analysis_server/lib/src/services/completion/common_usage_generated.dart#newcode6 pkg/analysis_server/lib/src/services/completion/common_usage_generated.dart:6: Would be nice to have a comment in ...
5 years, 9 months ago (2015-03-03 01:11:52 UTC) #3
lukechurch
Thanks! https://codereview.chromium.org/968283003/diff/1/pkg/analysis_server/lib/src/services/completion/common_usage_generated.dart File pkg/analysis_server/lib/src/services/completion/common_usage_generated.dart (right): https://codereview.chromium.org/968283003/diff/1/pkg/analysis_server/lib/src/services/completion/common_usage_generated.dart#newcode6 pkg/analysis_server/lib/src/services/completion/common_usage_generated.dart:6: On 2015/03/03 01:11:52, danrubel wrote: > Would be ...
5 years, 9 months ago (2015-03-03 01:15:37 UTC) #4
lukechurch
5 years, 9 months ago (2015-03-03 01:15:57 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as r44158 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698