Move the dart_precompiled function inside scoping function.

Move the dart_precompiled function inside scoping function.

Also make it a property of init.

This is also done for deferred hunks, allowing deferred loading to work
in CSP mode.

Long term I would like the precompiled function to go away, and move
the generated functions into the library-initializer when they are
 needed.

BUG=16898
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44162

[sigurdm, 2015-03-02 10:00:50]

sigurdm@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2015-03-02 14:33:13]

LGTM.

https://codereview.chromium.org/968163002/diff/50001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/968163002/diff/50001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:731:
$initName.${precompiledName} = function (\$collectedClasses) {
Use an "embedded" global instead of "init".
If you copied this pattern from somewhere consider it changing there too.

https://codereview.chromium.org/968163002/diff/50001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart
(right):

https://codereview.chromium.org/968163002/diff/50001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart:378: var
constructors = ${oldEmitter.initName}
use embedded-global access.
(again: if you saw this pattern somewhere else, consider changing it there too).

[sigurdm, 2015-03-03 09:31:43]

Committed patchset #5 (id:70001) manually as 44162 (presubmit successful).

[sigurdm, 2015-03-03 09:33:50]

https://codereview.chromium.org/968163002/diff/50001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/968163002/diff/50001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:731:
$initName.${precompiledName} = function (\$collectedClasses) {
On 2015/03/02 14:33:13, floitsch wrote:
> Use an "embedded" global instead of "init".
> If you copied this pattern from somewhere consider it changing there too.

Done.

https://codereview.chromium.org/968163002/diff/50001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart
(right):

https://codereview.chromium.org/968163002/diff/50001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart:378: var
constructors = ${oldEmitter.initName}
On 2015/03/02 14:33:13, floitsch wrote:
> use embedded-global access.
> (again: if you saw this pattern somewhere else, consider changing it there
too).

Done.