Issue 967633002: Remove the line number and file information from *all* folded frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 967633002: Remove the line number and file information from all folded frames. (Closed)

Created:
5 years, 9 months ago by nweiz

Modified:
5 years, 9 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/stack_trace@master

Target Ref:
refs/heads/master

Visibility:
Public.

Remove the line number and file information from *all* folded frames. Previously this was just done for core library frames, but the same logic applies to libraries like unittest where the implementation is irrelevant to user code. R=rnystrom@google.com BUG= Committed: https://github.com/dart-lang/stack_trace/commit/5f078f11b320895ce8297b503fd48b8fb560992b

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -11 lines)			Patch
M	CHANGELOG.md	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	README.md	View	1	2 chunks	+5 lines, -8 lines	0 comments	Download
M	lib/src/trace.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/chain_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/trace_test.dart	View		1 chunk	+20 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

nweiz

5 years, 9 months ago (2015-02-27 21:18:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
5f078f11b320895ce8297b503fd48b8fb560992b (presubmit successful).