Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1508)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 966803004: Generate fast-path CssStyleDeclaration properties from browser info (Closed)

Created:
5 years, 9 months ago by sra1
Modified:
5 years, 8 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org, ricow1, floitsch
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Generate fast-path CssStyleDeclaration properties from browser info We can tell all our suported browsers have style.backgroundColor so we can avoid the detection and vendor prefix logic. R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=44973

Patch Set 1 : #

Total comments: 7

Patch Set 2 : use native fields instead of JS accessors to get better inlining #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : Add fast path batch setter for known path #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5505 lines, -37 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +1465 lines, -14 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +4 lines, -1 line 0 comments Download
A tools/dom/scripts/cssProperties.html View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
A tools/dom/scripts/cssProperties.CSS21.txt View 1 2 1 chunk +102 lines, -0 lines 0 comments Download
A tools/dom/scripts/cssProperties.chrome40.txt View 1 chunk +358 lines, -0 lines 0 comments Download
A tools/dom/scripts/cssProperties.ff36.txt View 1 chunk +474 lines, -0 lines 0 comments Download
A tools/dom/scripts/cssProperties.iPad4Air.onGoogleSites.txt View 1 2 3 1 chunk +159 lines, -0 lines 0 comments Download
A tools/dom/scripts/cssProperties.ie10.txt View 1 chunk +296 lines, -0 lines 0 comments Download
A tools/dom/scripts/cssProperties.ie11.txt View 1 2 1 chunk +316 lines, -0 lines 0 comments Download
A tools/dom/scripts/cssProperties.ie9.txt View 1 chunk +182 lines, -0 lines 0 comments Download
A tools/dom/scripts/cssProperties.mobileSafari-8.2.txt View 1 2 1 chunk +159 lines, -0 lines 0 comments Download
A tools/dom/scripts/cssProperties.safari-7.1.3.txt View 1 chunk +399 lines, -0 lines 0 comments Download
M tools/dom/scripts/css_code_generator.py View 1 2 3 4 8 chunks +97 lines, -8 lines 0 comments Download
M tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate View 1 2 3 4 2 chunks +1469 lines, -14 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
sra1
5 years, 9 months ago (2015-03-04 03:17:26 UTC) #3
Alan Knight
https://codereview.chromium.org/966803004/diff/30011/tools/dom/scripts/cssProperties.CSS21.txt File tools/dom/scripts/cssProperties.CSS21.txt (right): https://codereview.chromium.org/966803004/diff/30011/tools/dom/scripts/cssProperties.CSS21.txt#newcode3 tools/dom/scripts/cssProperties.CSS21.txt:3: // This list was constructed by filtering CSS2.1 properties ...
5 years, 9 months ago (2015-03-04 17:49:32 UTC) #6
sra1
PTAL https://codereview.chromium.org/966803004/diff/30011/tools/dom/scripts/cssProperties.CSS21.txt File tools/dom/scripts/cssProperties.CSS21.txt (right): https://codereview.chromium.org/966803004/diff/30011/tools/dom/scripts/cssProperties.CSS21.txt#newcode3 tools/dom/scripts/cssProperties.CSS21.txt:3: // This list was constructed by filtering CSS2.1 ...
5 years, 9 months ago (2015-03-25 05:23:35 UTC) #7
Alan Knight
https://codereview.chromium.org/966803004/diff/30011/tools/dom/scripts/css_code_generator.py File tools/dom/scripts/css_code_generator.py (right): https://codereview.chromium.org/966803004/diff/30011/tools/dom/scripts/css_code_generator.py#newcode22 tools/dom/scripts/css_code_generator.py:22: 'cssProperties.ie9.txt', On 2015/03/25 05:23:35, sra1 wrote: > On 2015/03/04 ...
5 years, 9 months ago (2015-03-25 17:51:05 UTC) #8
sra1
Added ie11. For safety, also added the old CSS2.1 properties.
5 years, 9 months ago (2015-03-25 23:45:56 UTC) #12
Alan Knight
lgtm
5 years, 9 months ago (2015-03-26 00:02:46 UTC) #13
sra1
5 years, 8 months ago (2015-04-08 16:18:54 UTC) #14
Message was sent while issue was closed. 
Committed patchset #5 (id:190001) manually as 44973 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698