Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 966763002: Fix order of box and types for constructor-body invocations. (Closed)

Created:
5 years, 9 months ago by floitsch
Modified:
5 years, 9 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, asgerf
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix order of box and types for constructor-body invocations. BUG= http://dartbug.com/22590 R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=44130

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -7 lines) Patch
M pkg/compiler/lib/src/ssa/builder.dart View 2 chunks +9 lines, -7 lines 0 comments Download
A tests/language/constructor12_test.dart View 1 1 chunk +65 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
floitsch
5 years, 9 months ago (2015-02-27 15:05:50 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/966763002/diff/1/tests/language/constructor12_test.dart File tests/language/constructor12_test.dart (right): https://codereview.chromium.org/966763002/diff/1/tests/language/constructor12_test.dart#newcode44 tests/language/constructor12_test.dart:44: Expect.equals(3, b.foo()); What is testing? Shouldn't we (instead) ...
5 years, 9 months ago (2015-03-02 10:41:52 UTC) #3
floitsch
https://codereview.chromium.org/966763002/diff/1/tests/language/constructor12_test.dart File tests/language/constructor12_test.dart (right): https://codereview.chromium.org/966763002/diff/1/tests/language/constructor12_test.dart#newcode44 tests/language/constructor12_test.dart:44: Expect.equals(3, b.foo()); On 2015/03/02 10:41:52, Johnni Winther wrote: > ...
5 years, 9 months ago (2015-03-02 14:56:52 UTC) #4
floitsch
5 years, 9 months ago (2015-03-02 14:57:57 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 44130 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698