Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 966353002: pkg/shelf: add travis and code coverage settings (Closed)

Created:
5 years, 9 months ago by kevmoo
Modified:
5 years, 9 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/shelf.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : test stable and dev #

Patch Set 3 : tweaks #

Total comments: 2

Patch Set 4 : fix for install #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -1 line) Patch
A .travis.yml View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M README.md View 1 chunk +3 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
A test/test_all.dart View 1 chunk +25 lines, -0 lines 0 comments Download
A tool/travis.sh View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
kevmoo
5 years, 9 months ago (2015-03-02 04:16:15 UTC) #2
nweiz
https://codereview.chromium.org/966353002/diff/40001/tool/travis.sh File tool/travis.sh (right): https://codereview.chromium.org/966353002/diff/40001/tool/travis.sh#newcode10 tool/travis.sh:10: pub global activate dart_coveralls Can we put this in ...
5 years, 9 months ago (2015-03-02 19:08:42 UTC) #3
kevmoo
https://codereview.chromium.org/966353002/diff/40001/tool/travis.sh File tool/travis.sh (right): https://codereview.chromium.org/966353002/diff/40001/tool/travis.sh#newcode10 tool/travis.sh:10: pub global activate dart_coveralls On 2015/03/02 19:08:42, nweiz wrote: ...
5 years, 9 months ago (2015-03-03 18:12:18 UTC) #4
nweiz
lgtm
5 years, 9 months ago (2015-03-03 20:06:48 UTC) #5
kevmoo
5 years, 9 months ago (2015-03-03 20:07:08 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
411da1f63500fad4556e398df21a8edba69e3721 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698