Issue 96623004: Add a visitor for Elements

Issue 96623004: Add a visitor for Elements (Closed)

Created:
7 years ago by sigurdm

Modified:
7 years ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add a visitor for Elements Also make ElementX abstract. BUG= R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=30780

Patch Set 1 #

Total comments: 6

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+177 lines, -15 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/closure.dart	View	7 chunks	+13 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/elements/elements.dart	View	2 chunks	+4 lines, -0 lines	2 comments	Download
M	sdk/lib/_internal/compiler/implementation/elements/modelx.dart	View	21 chunks	+49 lines, -3 lines	2 comments	Download
A	sdk/lib/_internal/compiler/implementation/elements/visitor.dart	View	1 chunk	+89 lines, -0 lines	2 comments	Download
M	sdk/lib/_internal/compiler/implementation/scanner/class_element_parser.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/scanner/scannerlib.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/ssa.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js/mock_compiler.dart	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/type_checker_test.dart	View	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://codereview.chromium.org/96623004/diff/1/sdk/lib/_internal/compiler/implementation/elements/elements.dart File sdk/lib/_internal/compiler/implementation/elements/elements.dart (right): https://codereview.chromium.org/96623004/diff/1/sdk/lib/_internal/compiler/implementation/elements/elements.dart#newcode263 sdk/lib/_internal/compiler/implementation/elements/elements.dart:263: accept(ElementVisitor visitor) => visitor.visitElement(this); Shouldn't this just be ...

7 years ago (2013-11-29 11:44:50 UTC) #2

sigurdm

7 years ago (2013-11-29 12:29:52 UTC) #4

Message was sent while issue was closed.

Sorry - this was committed prematurely

Work continues in https://codereview.chromium.org/96873002 .

https://codereview.chromium.org/96623004/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/elements/elements.dart (right):

https://codereview.chromium.org/96623004/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/elements/elements.dart:263:
accept(ElementVisitor visitor) => visitor.visitElement(this);
On 2013/11/29 11:44:50, ahe wrote:
> Shouldn't this just be an abstract method?

Yes

https://codereview.chromium.org/96623004/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right):

https://codereview.chromium.org/96623004/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/elements/modelx.dart:1663:
visitor.visitSynthesizedConstructorElementX(this);
On 2013/11/29 11:44:50, ahe wrote:
> Add return.

Done.

https://codereview.chromium.org/96623004/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/elements/visitor.dart (right):

https://codereview.chromium.org/96623004/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/elements/visitor.dart:43: R
visitClassElementX(ClassElementX e) => visitBaseClassElementX(e);
On 2013/11/29 11:44:50, ahe wrote:
> Can we find a way to avoid having X-elements in this visitor?

yes

Expand Messages | Collapse Messages