Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 965753003: fix invocation completion with trailing stmt (Closed)

Created:
5 years, 9 months ago by danrubel
Modified:
5 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix invocation completion with trailing stmt BUG=dartbug.com/22365 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=44100

Patch Set 1 #

Total comments: 3

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -14 lines) Patch
M pkg/analysis_server/lib/src/services/completion/invocation_computer.dart View 5 chunks +135 lines, -8 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/local_declaration_visitor.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/socket_server.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 1 2 chunks +99 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/invocation_computer_test.dart View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
danrubel
5 years, 9 months ago (2015-02-27 16:41:03 UTC) #2
scheglov
I'm not aware if there was a change to assign propagated types in these cases. ...
5 years, 9 months ago (2015-02-27 17:59:14 UTC) #4
danrubel
https://codereview.chromium.org/965753003/diff/1/pkg/analysis_server/lib/src/services/completion/invocation_computer.dart File pkg/analysis_server/lib/src/services/completion/invocation_computer.dart (right): https://codereview.chromium.org/965753003/diff/1/pkg/analysis_server/lib/src/services/completion/invocation_computer.dart#newcode149 pkg/analysis_server/lib/src/services/completion/invocation_computer.dart:149: finished = true; On 2015/02/27 17:59:13, scheglov wrote: > ...
5 years, 9 months ago (2015-02-27 18:42:00 UTC) #5
danrubel
Committed patchset #2 (id:20001) manually as 44100 (presubmit successful).
5 years, 9 months ago (2015-02-27 18:42:51 UTC) #6
danrubel
5 years, 9 months ago (2015-02-27 21:05:09 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/965753003/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/completion/invocation_computer.dart
(right):

https://codereview.chromium.org/965753003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/completion/invocation_computer.dart:149:
finished = true;
On 2015/02/27 18:42:00, danrubel wrote:
> On 2015/02/27 17:59:13, scheglov wrote:
> > BTW, it might be slightly more efficient to throw an exception and stop
> visiting
> > the whole sub-tree.
> 
> Good point. I'll look at that in a subsequent CL.

https://codereview.chromium.org/967643002/

Powered by Google App Engine
This is Rietveld 408576698