Improved profiler view and inclusive profile tree

Improved profiler view and inclusive profile tree

TableTree improvements:
- Row's have flex-box divs in each table cell.
- To represent depth in tree a colored vertical bar for each depth level is shown
- Expanding tree nodes is now asynchronous and animates.
- Change cursor during tree expansion.

Observatory Profiler improvements:
- Improved appearance.
- Support for inclusive (main first) call trees.
- Replace tooltip hover with info toggle.
- Visual icon attributes for code, functions and call tree nodes.
- Fetching / Load status display.
- Cleaned up Code and Function kinds.

Profiler improvements:
- When not profiling the VM (--profile-vm) only walk the stack when we are in Dart code or have exited Dart code. This removes some native stack walker noise.
- Build inclusive (main first) call trees and send across service.

Notes for analyzer team:

Analyzer command line:

./out/ReleaseIA32/dart --keep-code --trace-profiler --profile-depth=128 --observe out/ReleaseIA32/dart-sdk/bin/snapshots/dartanalyzer.dart.snapshot --dart-sdk=out/ReleaseIA32/dart-sdk pkg/compiler/lib/src/dart2js.dart

Profiler settings:

- Tags: None or VM
- Mode: Function
- Direction: Bottom up

R=asiva@google.com, rmacnak@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44152

[Cutch, 2015-02-26 23:01:10]

johnmccutchan@google.com changed reviewers:
+ iposva@google.com

[Cutch, 2015-02-26 23:02:27]

johnmccutchan@google.com changed reviewers:
+ asiva@google.com
- iposva@google.com

[Cutch, 2015-02-27 23:37:17]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[siva, 2015-03-02 21:58:45]

lgtm

https://codereview.chromium.org/965593002/diff/60001/runtime/observatory/lib/...
File runtime/observatory/lib/src/app/view_model.dart (right):

https://codereview.chromium.org/965593002/diff/60001/runtime/observatory/lib/...
runtime/observatory/lib/src/app/view_model.dart:85: '#FF9800',
More readable const variables for these values?

https://codereview.chromium.org/965593002/diff/60001/runtime/observatory/lib/...
runtime/observatory/lib/src/app/view_model.dart:98: var backgroundColor =
'#FAFAFA';
Ditto comment.

https://codereview.chromium.org/965593002/diff/60001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/965593002/diff/60001/runtime/vm/object.cc#new...
runtime/vm/object.cc:12527: const bool is_stub = !obj.IsFunction();
It might be cleaner to have a
bool IsStub() const {
  return (raw_ptr()->owner_->GetClassId() == kFunctionCid);
}
method in class Code.

The method function() in class Code could also use it:
return IsStub() ? Function::null() : Function::RawCast(raw_ptr()->owner_).

https://codereview.chromium.org/965593002/diff/60001/runtime/vm/profiler.cc
File runtime/vm/profiler.cc (right):

https://codereview.chromium.org/965593002/diff/60001/runtime/vm/profiler.cc#n...
runtime/vm/profiler.cc:942: (isolate->vm_tag() == VMTag::kDartTagId);
const bool in_dart_code = (isolate->stub_code() != NULL) && !exited_dart_code;
should work?

[rmacnak, 2015-03-02 22:25:26]

lgtm

https://codereview.chromium.org/965593002/diff/60001/runtime/observatory/lib/...
File runtime/observatory/lib/src/app/view_model.dart (right):

https://codereview.chromium.org/965593002/diff/60001/runtime/observatory/lib/...
runtime/observatory/lib/src/app/view_model.dart:156: var _operation;
Consider Future _pendingOperation;

https://codereview.chromium.org/965593002/diff/60001/runtime/observatory/lib/...
runtime/observatory/lib/src/app/view_model.dart:220: _insertRow(index + i + 1,
row.children[i]);
row.children[i] -> child

https://codereview.chromium.org/965593002/diff/60001/runtime/observatory/lib/...
File runtime/observatory/lib/src/elements/cpu_profile.html (right):

https://codereview.chromium.org/965593002/diff/60001/runtime/observatory/lib/...
runtime/observatory/lib/src/elements/cpu_profile.html:125: <div
class="memberValue">{{ refreshTime }} (fetched in {{ fetchTime  }}) (loaded in
{{ loadTime }})</div>
units: fetched in XX seconds, loaded in XX seconds

https://codereview.chromium.org/965593002/diff/60001/runtime/vm/profiler_serv...
File runtime/vm/profiler_service.cc (right):

https://codereview.chromium.org/965593002/diff/60001/runtime/vm/profiler_serv...
runtime/vm/profiler_service.cc:2105: JSONArray exclusive_trie(&obj,
"inclusiveCodeTrie");
inclusive_trie

https://codereview.chromium.org/965593002/diff/60001/runtime/vm/scope_timer.h
File runtime/vm/scope_timer.h (right):

https://codereview.chromium.org/965593002/diff/60001/runtime/vm/scope_timer.h...
runtime/vm/scope_timer.h:37: OS::Print("%s: %f seconds (%" Pd64 " \u00B5)\n",
name_, seconds, elapsed);
XX u -> XX us

[Cutch, 2015-03-02 22:48:19]

https://codereview.chromium.org/965593002/diff/60001/runtime/observatory/lib/...
File runtime/observatory/lib/src/app/view_model.dart (right):

https://codereview.chromium.org/965593002/diff/60001/runtime/observatory/lib/...
runtime/observatory/lib/src/app/view_model.dart:85: '#FF9800',
On 2015/03/02 21:58:44, siva wrote:
> More readable const variables for these values?

Done.

https://codereview.chromium.org/965593002/diff/60001/runtime/observatory/lib/...
runtime/observatory/lib/src/app/view_model.dart:98: var backgroundColor =
'#FAFAFA';
On 2015/03/02 21:58:44, siva wrote:
> Ditto comment.

Done.

https://codereview.chromium.org/965593002/diff/60001/runtime/observatory/lib/...
runtime/observatory/lib/src/app/view_model.dart:156: var _operation;
On 2015/03/02 22:25:26, rmacnak wrote:
> Consider Future _pendingOperation;

Done.

https://codereview.chromium.org/965593002/diff/60001/runtime/observatory/lib/...
runtime/observatory/lib/src/app/view_model.dart:220: _insertRow(index + i + 1,
row.children[i]);
On 2015/03/02 22:25:26, rmacnak wrote:
> row.children[i] -> child

Done.

https://codereview.chromium.org/965593002/diff/60001/runtime/observatory/lib/...
File runtime/observatory/lib/src/elements/cpu_profile.html (right):

https://codereview.chromium.org/965593002/diff/60001/runtime/observatory/lib/...
runtime/observatory/lib/src/elements/cpu_profile.html:125: <div
class="memberValue">{{ refreshTime }} (fetched in {{ fetchTime  }}) (loaded in
{{ loadTime }})</div>
On 2015/03/02 22:25:26, rmacnak wrote:
> units: fetched in XX seconds, loaded in XX seconds

These are formatted with formatTime which adds units where appropriate.

https://codereview.chromium.org/965593002/diff/60001/runtime/vm/profiler_serv...
File runtime/vm/profiler_service.cc (right):

https://codereview.chromium.org/965593002/diff/60001/runtime/vm/profiler_serv...
runtime/vm/profiler_service.cc:2105: JSONArray exclusive_trie(&obj,
"inclusiveCodeTrie");
On 2015/03/02 22:25:26, rmacnak wrote:
> inclusive_trie

Done.

https://codereview.chromium.org/965593002/diff/60001/runtime/vm/scope_timer.h
File runtime/vm/scope_timer.h (right):

https://codereview.chromium.org/965593002/diff/60001/runtime/vm/scope_timer.h...
runtime/vm/scope_timer.h:37: OS::Print("%s: %f seconds (%" Pd64 " \u00B5)\n",
name_, seconds, elapsed);
On 2015/03/02 22:25:26, rmacnak wrote:
> XX u -> XX us

Done.

[Cutch, 2015-03-02 23:02:04]

Committed patchset #6 (id:100001) manually as 44152 (presubmit successful).