Add debug information to verify that we actually get the onDone event send to the driver page.

Add debug information to verify that we actually get the onDone event send to the driver page.

I am aware that we should not clutter up the message that we show to developers, but I think it is important to validate that we actually send the onDone message to the driver page.

We should also put in functionality for tracking network errors in the browser_controller generated js (+potentially retrying the send of the message)

R=kustermann@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30771

[kustermann, 2013-11-29 08:17:56]

LGTM

https://codereview.chromium.org/96503002/diff/1/tools/testing/dart/test_contr...
File tools/testing/dart/test_controller.js (right):

https://codereview.chromium.org/96503002/diff/1/tools/testing/dart/test_contr...
tools/testing/dart/test_controller.js:153: recordEvent('debug', 'Sending onDone
event to driver.');
Rename to 'Sending events to driver page.'

(why did you call it 'onDone'?)

[ricow1, 2013-11-29 08:21:52]

https://codereview.chromium.org/96503002/diff/1/tools/testing/dart/test_contr...
File tools/testing/dart/test_controller.js (right):

https://codereview.chromium.org/96503002/diff/1/tools/testing/dart/test_contr...
tools/testing/dart/test_controller.js:153: recordEvent('debug', 'Sending onDone
event to driver.');
On 2013/11/29 08:17:56, kustermann wrote:
> Rename to 'Sending events to driver page.'
> 
> (why did you call it 'onDone'?)
So this should have been isDone, I only do this if we have the isDone bool set

[kustermann, 2013-11-29 08:26:23]

https://codereview.chromium.org/96503002/diff/1/tools/testing/dart/test_contr...
File tools/testing/dart/test_controller.js (right):

https://codereview.chromium.org/96503002/diff/1/tools/testing/dart/test_contr...
tools/testing/dart/test_controller.js:153: recordEvent('debug', 'Sending onDone
event to driver.');
On 2013/11/29 08:21:52, ricow1 wrote:
> On 2013/11/29 08:17:56, kustermann wrote:
> > Rename to 'Sending events to driver page.'
> > 
> > (why did you call it 'onDone'?)
> So this should have been isDone, I only do this if we have the isDone bool set
> 

Sorry about that, please remove the 'if (isDone) {}'. 
I think it would be beneficial if we get this info every time we contact the
driving page (be it a status update or the final update)

So do something like this:

recordEvent('debug', 'Sending events to driver page (isFirstMessage = ' +
isFirstMessage + ', isStatusUpdate = ' + isStatusUpdate + ', isDone = ' + isDone
+ ')');

unconditionally

[ricow1, 2013-11-29 08:57:25]

On 2013/11/29 08:26:23, kustermann wrote:
>
https://codereview.chromium.org/96503002/diff/1/tools/testing/dart/test_contr...
> File tools/testing/dart/test_controller.js (right):
> 
>
https://codereview.chromium.org/96503002/diff/1/tools/testing/dart/test_contr...
> tools/testing/dart/test_controller.js:153: recordEvent('debug', 'Sending
onDone
> event to driver.');
> On 2013/11/29 08:21:52, ricow1 wrote:
> > On 2013/11/29 08:17:56, kustermann wrote:
> > > Rename to 'Sending events to driver page.'
> > > 
> > > (why did you call it 'onDone'?)
> > So this should have been isDone, I only do this if we have the isDone bool
set
> > 
> 
> Sorry about that, please remove the 'if (isDone) {}'. 
> I think it would be beneficial if we get this info every time we contact the
> driving page (be it a status update or the final update)
> 
> So do something like this:
> 
> recordEvent('debug', 'Sending events to driver page (isFirstMessage = ' +
> isFirstMessage + ', isStatusUpdate = ' + isStatusUpdate + ', isDone = ' +
isDone
> + ')');
> 
> unconditionally

sounds good, done

[ricow1, 2013-11-29 08:57:51]

Committed patchset #1 manually as r30771 (presubmit successful).