Issue 964853002: Let CSP-mode-flag be available as a foreign_helper constant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 964853002: Let CSP-mode-flag be available as a foreign_helper constant. (Closed)

Created:
5 years, 9 months ago by sigurdm

Modified:
5 years, 9 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

Let CSP-mode-flag be available as a foreign_helper constant. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=44091

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -9 lines)			Patch
M	pkg/compiler/lib/src/ssa/builder.dart	View	1 chunk	+11 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/compiler/js_lib/js_helper.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/js_lib/js_mirrors.dart	View	2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

floitsch

LGTM. Ideally the possible flags should be in an enum in the shared directory. Not ...

5 years, 9 months ago (2015-02-27 12:51:52 UTC) #3

sigurdm

5 years, 9 months ago (2015-02-27 13:05:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 44091 (presubmit successful).