Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 964553004: Analyze locals in await for loops as inside a try-finally. (Closed)

Created:
5 years, 9 months ago by sigurdm
Modified:
5 years, 9 months ago
Reviewers:
karlklose, floitsch
CC:
reviews_dartlang.org, Lasse Reichstein Nielsen
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Analyze locals in await for loops as inside a try-finally. Otherwise they do not get the right boxing behavior. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=44166

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Refer directly to class in dartdoc comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
M pkg/compiler/lib/src/closure.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 1 chunk +9 lines, -0 lines 0 comments Download
A tests/language/await_for_use_local_test.dart View 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
sigurdm
5 years, 9 months ago (2015-03-03 08:56:54 UTC) #4
karlklose
https://codereview.chromium.org/964553004/diff/40001/pkg/compiler/lib/src/ssa/builder.dart File pkg/compiler/lib/src/ssa/builder.dart (right): https://codereview.chromium.org/964553004/diff/40001/pkg/compiler/lib/src/ssa/builder.dart#newcode6028 pkg/compiler/lib/src/ssa/builder.dart:6028: /// `../closure.dart`. Maybe use the class name in '[]' ...
5 years, 9 months ago (2015-03-03 10:00:50 UTC) #6
floitsch
LGTM.
5 years, 9 months ago (2015-03-03 12:16:50 UTC) #7
sigurdm
https://codereview.chromium.org/964553004/diff/40001/pkg/compiler/lib/src/ssa/builder.dart File pkg/compiler/lib/src/ssa/builder.dart (right): https://codereview.chromium.org/964553004/diff/40001/pkg/compiler/lib/src/ssa/builder.dart#newcode6028 pkg/compiler/lib/src/ssa/builder.dart:6028: /// `../closure.dart`. On 2015/03/03 10:00:50, karlklose wrote: > Maybe ...
5 years, 9 months ago (2015-03-03 12:40:57 UTC) #8
sigurdm
5 years, 9 months ago (2015-03-03 12:41:20 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:60001) manually as 44166 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698