Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 964253003: Fails under ia32 (Closed)

Created:
5 years, 9 months ago by terry
Modified:
5 years, 9 months ago
Reviewers:
ricow1, Bill Hesse, siva
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fails under ia32 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tests/html/html.status View 1 chunk +4 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
terry
William/Rico, I fixed DomPoint and WebKitPoint with changes made in 39 roll (as I moved ...
5 years, 9 months ago (2015-03-02 02:27:41 UTC) #2
ricow1
Terry: There is a delay in you committing a change to the dart repo and ...
5 years, 9 months ago (2015-03-02 07:30:08 UTC) #3
ricow1
https://codereview.chromium.org/964253003/diff/20001/tests/html/html.status File tests/html/html.status (right): https://codereview.chromium.org/964253003/diff/20001/tests/html/html.status#newcode179 tests/html/html.status:179: [ $arch == ia32 && $compiler == dart2js && ...
5 years, 9 months ago (2015-03-02 08:31:22 UTC) #4
ricow1
Committed patchset #2 (id:20001) manually as 44121 (presubmit successful).
5 years, 9 months ago (2015-03-02 08:32:04 UTC) #5
ricow1
5 years, 9 months ago (2015-03-02 08:32:38 UTC) #6
Message was sent while issue was closed.
I was not allowed to upload a new patchset - I landed this without the arch=ia32

Powered by Google App Engine
This is Rietveld 408576698