Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 963893002: Make padding consistent across all stack traces for Chain.toString(). (Closed)

Created:
5 years, 9 months ago by nweiz
Modified:
5 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/stack_trace@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make padding consistent across all stack traces for Chain.toString(). R=rnystrom@google.com Committed: https://github.com/dart-lang/stack_trace/commit/d558ccba41b97698df24109a3503139d99508e62

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -21 lines) Patch
M CHANGELOG.md View 1 chunk +2 lines, -0 lines 0 comments Download
M README.md View 2 chunks +16 lines, -16 lines 0 comments Download
M lib/src/chain.dart View 4 chunks +20 lines, -4 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/chain_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 9 months ago (2015-02-27 21:19:42 UTC) #1
Bob Nystrom
LGTM. Don't forget to tag the commit and publish it.
5 years, 9 months ago (2015-03-02 20:39:49 UTC) #2
nweiz
5 years, 9 months ago (2015-03-02 22:41:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d558ccba41b97698df24109a3503139d99508e62 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698