Do not update original descriptor when building new one.

Do not update original descriptor when building new one.

BUG=
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44320

[herhut, 2015-02-26 12:09:47]

herhut@google.com changed reviewers:
+ ahe@google.com

[herhut, 2015-02-26 12:15:08]

I checked the code and came to the conclusion that the original descriptor is
not used by the mirror system. It uses two arrays (functions and classes) to
find all (static) functions and classes of a library but uses the real
prototypes for instance members.

This is backed up by all tests still passing.

[floitsch, 2015-02-26 13:02:53]

floitsch@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2015-02-26 13:02:54]

LGTM.

https://codereview.chromium.org/963453002/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart
(right):

https://codereview.chromium.org/963453002/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart:188:
function addStubs(descriptor, array, name, isStatic, functions) {
while you are at it...

imho descriptor is a really bad name here.
Also add comment what each is.

[floitsch, 2015-02-27 16:17:14]

Did you address the comment?

[herhut, 2015-03-09 13:33:59]

https://chromiumcodereview.appspot.com/963453002/diff/1/pkg/compiler/lib/src/...
File pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart
(right):

https://chromiumcodereview.appspot.com/963453002/diff/1/pkg/compiler/lib/src/...
pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart:188:
function addStubs(descriptor, array, name, isStatic, functions) {
On 2015/02/26 13:02:54, floitsch wrote:
> while you are at it...
> 
> imho descriptor is a really bad name here.
> Also add comment what each is.

I will do this in a later CL to avoid loads of merge conflicts down the road...

[herhut, 2015-03-09 13:35:48]

Committed patchset #1 (id:1) manually as 44320 (presubmit successful).