Issue 96323006: Support newInstance() for class mirrors of generic classes.

Issue 96323006: Support newInstance() for class mirrors of generic classes. (Closed)

Created:
7 years ago by zarah

Modified:
7 years ago

Reviewers:
Johnni Winther, ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support newInstance() for class mirrors of generic classes. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=31213

Patch Set 2 : Addressed comments. #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -31 lines)			Patch
M	sdk/lib/_internal/lib/js_mirrors.dart	View	1	6 chunks	+53 lines, -19 lines	0 comments	Download
M	tests/lib/lib.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/lib/mirrors/initializing_formals_test.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/lib/mirrors/new_instance_with_type_arguments_test.dart	View	1	2 chunks	+3 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/96323006/diff/20001/sdk/lib/_internal/lib/js_mirrors.dart File sdk/lib/_internal/lib/js_mirrors.dart (right): https://codereview.chromium.org/96323006/diff/20001/sdk/lib/_internal/lib/js_mirrors.dart#newcode1058 sdk/lib/_internal/lib/js_mirrors.dart:1058: positionalArguments, Indent 1 character. https://codereview.chromium.org/96323006/diff/20001/sdk/lib/_internal/lib/js_mirrors.dart#newcode1059 sdk/lib/_internal/lib/js_mirrors.dart:1059: namedArguments); Ditto. ...

7 years ago (2013-12-02 07:59:54 UTC) #2

zarah

https://codereview.chromium.org/96323006/diff/20001/sdk/lib/_internal/lib/js_mirrors.dart File sdk/lib/_internal/lib/js_mirrors.dart (right): https://codereview.chromium.org/96323006/diff/20001/sdk/lib/_internal/lib/js_mirrors.dart#newcode1058 sdk/lib/_internal/lib/js_mirrors.dart:1058: positionalArguments, On 2013/12/02 07:59:54, Johnni Winther wrote: > Indent ...

7 years ago (2013-12-18 08:39:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r31213 (presubmit successful).

Expand Messages | Collapse Messages