Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 962603002: Typecheck return with respect to async. (Closed)

Created:
5 years, 10 months ago by Johnni Winther
Modified:
5 years, 9 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Typecheck return with respect to async. BUG=http://dartbug.com/22552 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=44128

Patch Set 1 #

Patch Set 2 : Allow return; in generators. #

Total comments: 2

Patch Set 3 : Updated and tested. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -59 lines) Patch
M pkg/compiler/lib/src/resolution/members.dart View 1 2 chunks +25 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/tree/nodes.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 1 2 12 chunks +45 lines, -39 lines 0 comments Download
M pkg/compiler/lib/src/warnings.dart View 1 2 chunks +18 lines, -1 line 0 comments Download
M tests/compiler/dart2js/mock_libraries.dart View 1 chunk +6 lines, -1 line 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 1 2 3 chunks +47 lines, -2 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 2 chunks +0 lines, -8 lines 0 comments Download
M tests/language/sync_generator2_test.dart View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Johnni Winther
5 years, 10 months ago (2015-02-26 14:16:23 UTC) #2
Johnni Winther
PTAL
5 years, 10 months ago (2015-02-26 15:04:13 UTC) #3
floitsch
LGTM, but add tests for "=>" functions. https://codereview.chromium.org/962603002/diff/20001/pkg/compiler/lib/src/typechecker.dart File pkg/compiler/lib/src/typechecker.dart (right): https://codereview.chromium.org/962603002/diff/20001/pkg/compiler/lib/src/typechecker.dart#newcode1591 pkg/compiler/lib/src/typechecker.dart:1591: case AsyncMarker.ASYNC: ...
5 years, 10 months ago (2015-02-26 15:24:14 UTC) #4
Johnni Winther
PTAL https://codereview.chromium.org/962603002/diff/20001/pkg/compiler/lib/src/typechecker.dart File pkg/compiler/lib/src/typechecker.dart (right): https://codereview.chromium.org/962603002/diff/20001/pkg/compiler/lib/src/typechecker.dart#newcode1591 pkg/compiler/lib/src/typechecker.dart:1591: case AsyncMarker.ASYNC: On 2015/02/26 15:24:14, floitsch wrote: > ...
5 years, 9 months ago (2015-03-02 10:30:58 UTC) #5
floitsch
LGTM.
5 years, 9 months ago (2015-03-02 10:33:30 UTC) #6
Johnni Winther
5 years, 9 months ago (2015-03-02 13:06:34 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 44128 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698