Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 961823004: Fix for the change/save/undo race condition. (Closed)

Created:
5 years, 10 months ago by scheglov
Modified:
5 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for the change/save/undo race condition. As we found out, it is not safe to compare file modification times. On some OSs, such as OSX with its HFS+ file modification time accuracy is just 1 second, and it is quite possible that a file is modified more than once in 1 second. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44080

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -9 lines) Patch
M pkg/analyzer/lib/src/generated/engine.dart View 6 chunks +25 lines, -9 lines 0 comments Download
A pkg/analyzer/lib/src/util/lru_map.dart View 1 chunk +64 lines, -0 lines 1 comment Download
A pkg/analyzer/test/src/util/lru_map_test.dart View 1 chunk +97 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/util/test_all.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
5 years, 10 months ago (2015-02-26 22:15:35 UTC) #1
Paul Berry
lgtm
5 years, 10 months ago (2015-02-26 22:23:12 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/961823004/diff/1/pkg/analyzer/lib/src/util/lru_map.dart File pkg/analyzer/lib/src/util/lru_map.dart (right): https://codereview.chromium.org/961823004/diff/1/pkg/analyzer/lib/src/util/lru_map.dart#newcode21 pkg/analyzer/lib/src/util/lru_map.dart:21: // final LinkedHashSet<K> _lastKeys = new LinkedHashSet<K>(); Remove ...
5 years, 10 months ago (2015-02-26 22:29:57 UTC) #3
scheglov
5 years, 10 months ago (2015-02-26 22:32:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44080 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698