Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 961483002: Fix isolate lifecycle handling in service library (Closed)

Created:
5 years, 10 months ago by Cutch
Modified:
5 years, 10 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix isolate lifecycle handling in service library - Use IsolateCreated and IsolateShutdown events to edit the VM's isolate cache directly. - IsolateCreated and IsolateShutdown events are owned by the VM. - When eagerly loading a new isolate, consume any errors rather than letting them bubble up to the application level. - When reloading the VM perform an edit the isolate cache instead of replacing it. - When reloading the VM do not reload all isolates. - Fix flaky coverage_test fail by delaying setting the breakpoint. - Add isolate lifecycle unit test. - Make the isolate cache observable and send an observable notification that the 'isolates' property has changed when editing the isolate cache. R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=44056

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+360 lines, -131 lines) Patch
M runtime/observatory/lib/service_common.dart View 3 chunks +33 lines, -34 lines 0 comments Download
M runtime/observatory/lib/src/elements/vm_view.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 3 chunks +146 lines, -83 lines 0 comments Download
M runtime/observatory/test/coverage_test.dart View 2 chunks +9 lines, -6 lines 0 comments Download
A runtime/observatory/test/isolate_lifecycle_test.dart View 1 chunk +101 lines, -0 lines 0 comments Download
M runtime/observatory/test/test_helper.dart View 4 chunks +70 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
5 years, 10 months ago (2015-02-25 21:13:20 UTC) #2
rmacnak
LGTM
5 years, 10 months ago (2015-02-25 22:44:12 UTC) #3
Cutch
5 years, 10 months ago (2015-02-26 17:01:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 44056 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698