Issue 961443005: Fix Range::Mul for fully non-positive ranges.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 961443005: Fix Range::Mul for fully non-positive ranges. (Closed)

Created:
5 years, 10 months ago by Vyacheslav Egorov (Google)

Modified:
5 years, 10 months ago

Reviewers:
Florian Schneider, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

Fix Range::Mul for fully non-positive ranges. BUG=http://dartbug.com/22541 R=fschneider@google.com, iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=44046

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -12 lines)			Patch
M	runtime/vm/constant_propagator.cc	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	runtime/vm/flow_graph_range_analysis.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_range_analysis.cc	View	2 chunks	+27 lines, -6 lines	0 comments	Download
A	tests/language/vm/regress_22541_vm_test.dart	View	1 chunk	+22 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

Vyacheslav Egorov (Google)

5 years, 10 months ago (2015-02-26 12:41:05 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 44046 (presubmit successful).