Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 961003005: Add a flag to control the use of color in the test runner. (Closed)

Created:
5 years, 9 months ago by nweiz
Modified:
5 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org, kevmoo
Base URL:
git@github.com:dart-lang/unittest@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a flag to control the use of color in the test runner. See #19 R=rnystrom@google.com Committed: https://github.com/dart-lang/unittest/commit/5f3a32218c8d7b4fb8395bd39f67e7dd537e4f21

Patch Set 1 #

Total comments: 5

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -32 lines) Patch
M bin/unittest.dart View 2 chunks +5 lines, -1 line 0 comments Download
M lib/src/runner/console_reporter.dart View 1 3 chunks +20 lines, -16 lines 0 comments Download
M lib/src/util/io.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M test/runner_test.dart View 4 chunks +19 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
5 years, 9 months ago (2015-03-02 23:57:25 UTC) #2
Bob Nystrom
Two nits/suggestions, but LGTM! https://codereview.chromium.org/961003005/diff/1/lib/src/runner/console_reporter.dart File lib/src/runner/console_reporter.dart (right): https://codereview.chromium.org/961003005/diff/1/lib/src/runner/console_reporter.dart#newcode26 lib/src/runner/console_reporter.dart:26: final String _green; Not that ...
5 years, 9 months ago (2015-03-03 00:28:57 UTC) #3
nweiz
Code review changes
5 years, 9 months ago (2015-03-03 00:46:31 UTC) #4
nweiz
https://codereview.chromium.org/961003005/diff/1/lib/src/runner/console_reporter.dart File lib/src/runner/console_reporter.dart (right): https://codereview.chromium.org/961003005/diff/1/lib/src/runner/console_reporter.dart#newcode26 lib/src/runner/console_reporter.dart:26: final String _green; On 2015/03/03 00:28:57, Bob Nystrom wrote: ...
5 years, 9 months ago (2015-03-03 00:46:44 UTC) #5
nweiz
5 years, 9 months ago (2015-03-03 00:47:01 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
5f3a32218c8d7b4fb8395bd39f67e7dd537e4f21 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698