Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 960723002: Add a CompilerPool class. (Closed)

Created:
5 years, 10 months ago by nweiz
Modified:
5 years, 9 months ago
Reviewers:
Bob Nystrom, kevmoo
CC:
reviews_dartlang.org, kevmoo
Base URL:
git@github.com:dart-lang/unittest@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a CompilerPool class. This will allow the test runner to compile test files to JavaScript. It runs dart2js instances in parallel but prints their output sequentially. See #5 R=rnystrom@google.com, kevmoo@google.com Committed: https://github.com/dart-lang/unittest/commit/3bd1e9d3bca581ff0f28e0a1bc422778d135b9c5

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review changes #

Patch Set 3 : Move sdkDir to lib/. #

Patch Set 4 : Fix library name. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -2 lines) Patch
A lib/src/runner/browser/compiler_pool.dart View 1 1 chunk +134 lines, -0 lines 0 comments Download
M lib/src/util/io.dart View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M test/io.dart View 1 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
nweiz
5 years, 10 months ago (2015-02-26 02:15:20 UTC) #1
nweiz
Sending to Bob instead.
5 years, 9 months ago (2015-02-27 20:43:40 UTC) #3
Bob Nystrom
https://codereview.chromium.org/960723002/diff/1/lib/src/runner/browser/compiler_pool.dart File lib/src/runner/browser/compiler_pool.dart (right): https://codereview.chromium.org/960723002/diff/1/lib/src/runner/browser/compiler_pool.dart#newcode65 lib/src/runner/browser/compiler_pool.dart:65: var dart2jsPath = "/usr/local/google/home/nweiz/goog/dart/dart/out/ReleaseIA32/dart-sdk/bin/dart2js"; This path has limited portability. ...
5 years, 9 months ago (2015-02-27 21:04:40 UTC) #4
kevmoo
https://codereview.chromium.org/960723002/diff/1/lib/src/runner/browser/compiler_pool.dart File lib/src/runner/browser/compiler_pool.dart (right): https://codereview.chromium.org/960723002/diff/1/lib/src/runner/browser/compiler_pool.dart#newcode38 lib/src/runner/browser/compiler_pool.dart:38: /// If [parallel] isn't provided, it defaults to 4. ...
5 years, 9 months ago (2015-02-27 21:12:26 UTC) #6
nweiz
Code review changes
5 years, 9 months ago (2015-02-27 21:17:28 UTC) #7
nweiz
https://codereview.chromium.org/960723002/diff/1/lib/src/runner/browser/compiler_pool.dart File lib/src/runner/browser/compiler_pool.dart (right): https://codereview.chromium.org/960723002/diff/1/lib/src/runner/browser/compiler_pool.dart#newcode38 lib/src/runner/browser/compiler_pool.dart:38: /// If [parallel] isn't provided, it defaults to 4. ...
5 years, 9 months ago (2015-02-27 21:17:34 UTC) #8
Bob Nystrom
lgtm
5 years, 9 months ago (2015-02-27 21:46:14 UTC) #9
nweiz
5 years, 9 months ago (2015-02-28 00:35:58 UTC) #10
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
3bd1e9d3bca581ff0f28e0a1bc422778d135b9c5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698