Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 96063006: Add @reflectable to NoSuchMethodModel (Closed)

Created:
7 years ago by ahe
Modified:
7 years ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add @reflectable to NoSuchMethodModel R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=30851

Patch Set 1 #

Patch Set 2 : Moved annotation and added TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M dart/pkg/observe/test/path_observer_test.dart View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
ahe
This annotation is necessary for this test to continue to work after CL 27524003.
7 years ago (2013-11-29 18:07:03 UTC) #1
Jennifer Messerly
LGTM. Thank you!
7 years ago (2013-12-02 19:39:21 UTC) #2
ahe
Trivial change, but please take another look :-)
7 years ago (2013-12-02 20:25:22 UTC) #3
Jennifer Messerly
lgtm. Thanks again for tracking that down!
7 years ago (2013-12-02 20:31:25 UTC) #4
ahe
7 years ago (2013-12-04 11:14:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r30851 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698