Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 959843002: Fix real_version_test on Windows. (Closed)

Created:
5 years, 10 months ago by Bob Nystrom
Modified:
5 years, 10 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix real_version_test on Windows. BUG=https://code.google.com/p/dart/issues/detail?id=22543 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=44029

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -14 lines) Patch
M sdk/lib/_internal/pub/lib/src/io.dart View 1 chunk +1 line, -11 lines 0 comments Download
M sdk/lib/_internal/pub/test/real_version_test.dart View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Bob Nystrom
I'm still not sure why this only breaks on Windows but what the test was ...
5 years, 10 months ago (2015-02-25 18:46:32 UTC) #2
nweiz
lgtm
5 years, 10 months ago (2015-02-25 20:19:04 UTC) #3
Bob Nystrom
5 years, 10 months ago (2015-02-25 20:34:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44029 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698