Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 959383004: Add a host script to run in a browser and start iframes for suites. (Closed)

Created:
5 years, 9 months ago by nweiz
Modified:
5 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/unittest@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a host script to run in a browser and start iframes for suites. See #5 R=rnystrom@google.com Committed: https://github.com/dart-lang/unittest/commit/0a07c236d9aac77f70a84e8d1fc2869f04121895

Patch Set 1 #

Total comments: 9

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14217 lines, -3 lines) Patch
A lib/src/runner/browser/static/host.dart View 1 1 chunk +141 lines, -0 lines 0 comments Download
A lib/src/runner/browser/static/host.dart.js View 1 chunk +14006 lines, -0 lines 0 comments Download
A lib/src/runner/browser/static/host.dart.js.map View 1 chunk +8 lines, -0 lines 0 comments Download
A lib/src/runner/browser/static/index.html View 1 chunk +9 lines, -0 lines 0 comments Download
M lib/src/util/multi_channel.dart View 4 chunks +5 lines, -3 lines 0 comments Download
A lib/src/util/stream_channel.dart View 1 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
5 years, 9 months ago (2015-02-27 21:26:26 UTC) #2
Bob Nystrom
LGTM, but I can't say I understood much of what I was looking at. https://codereview.chromium.org/959383004/diff/1/lib/src/runner/browser/static/host.dart ...
5 years, 9 months ago (2015-03-02 20:31:31 UTC) #3
nweiz
I'm happy to explain the code if you're interested. https://codereview.chromium.org/959383004/diff/1/lib/src/runner/browser/static/host.dart File lib/src/runner/browser/static/host.dart (right): https://codereview.chromium.org/959383004/diff/1/lib/src/runner/browser/static/host.dart#newcode29 lib/src/runner/browser/static/host.dart:29: ...
5 years, 9 months ago (2015-03-02 22:39:42 UTC) #4
nweiz
Code review changes
5 years, 9 months ago (2015-03-02 22:40:05 UTC) #5
nweiz
5 years, 9 months ago (2015-03-02 22:40:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0a07c236d9aac77f70a84e8d1fc2869f04121895 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698