Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 958753002: Add an IframeListener class for shepherding browser tests. (Closed)

Created:
5 years, 10 months ago by nweiz
Modified:
5 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org, kevmoo
Base URL:
git@github.com:dart-lang/unittest@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -0 lines) Patch
A lib/src/runner/browser/iframe_listener.dart View 1 1 chunk +161 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
nweiz
5 years, 10 months ago (2015-02-26 00:17:13 UTC) #1
nweiz
Sending to Bob instead.
5 years, 9 months ago (2015-02-27 20:44:03 UTC) #3
Bob Nystrom
lgtm https://codereview.chromium.org/958753002/diff/1/lib/src/runner/browser/iframe_listener.dart File lib/src/runner/browser/iframe_listener.dart (right): https://codereview.chromium.org/958753002/diff/1/lib/src/runner/browser/iframe_listener.dart#newcode83 lib/src/runner/browser/iframe_listener.dart:83: if (message.origin != window.location.origin) return; What's this for? ...
5 years, 9 months ago (2015-02-27 21:09:49 UTC) #4
nweiz
Code review changes
5 years, 9 months ago (2015-02-27 21:22:43 UTC) #5
nweiz
https://codereview.chromium.org/958753002/diff/1/lib/src/runner/browser/iframe_listener.dart File lib/src/runner/browser/iframe_listener.dart (right): https://codereview.chromium.org/958753002/diff/1/lib/src/runner/browser/iframe_listener.dart#newcode83 lib/src/runner/browser/iframe_listener.dart:83: if (message.origin != window.location.origin) return; On 2015/02/27 21:09:49, Bob ...
5 years, 9 months ago (2015-02-27 21:23:45 UTC) #6
nweiz
5 years, 9 months ago (2015-02-27 21:23:58 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
602ab1ab022bf2412b9320e272655dff6368dc9d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698