Issue 958393002: Change EventSource parameter from title to url, to match idl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 958393002: Change EventSource parameter from title to url, to match idl (Closed)

Created:
5 years, 9 months ago by Alan Knight

Modified:
5 years, 9 months ago

Reviewers:
terry

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

Change EventSource parameter from title to url, to match idl BUG= R=terry@google.com Committed: https://code.google.com/p/dart/source/detail?r=44138

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_EventSource.darttemplate	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (1 generated)

terry

lgtm - You'll need to re-sync and re-run go.sh because of the new IDLs just ...

5 years, 9 months ago (2015-02-27 20:36:42 UTC) #3

Alan Knight

Committed patchset #2 (id:20001) manually as 44138 (presubmit successful).

5 years, 9 months ago (2015-03-02 18:45:04 UTC) #4

Message was sent while issue was closed.

TBR