Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 958183002: Fix Win64 flakey crash related to reading from stack guard page. (Closed)

Created:
5 years, 10 months ago by Cutch
Modified:
5 years, 10 months ago
Reviewers:
koda
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix Win64 flakey crash related to reading from stack guard page. Avoid reading from stack if we aren't executing Dart code. BUG= Committed: https://code.google.com/p/dart/source/detail?r=44074

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M runtime/vm/profiler.cc View 3 chunks +11 lines, -7 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
Cutch
TBR
5 years, 10 months ago (2015-02-26 20:41:28 UTC) #2
Cutch
Committed patchset #1 (id:1) manually as 44074 (presubmit successful).
5 years, 10 months ago (2015-02-26 20:41:49 UTC) #3
koda
5 years, 10 months ago (2015-02-26 21:05:31 UTC) #4
Message was sent while issue was closed. 
https://codereview.chromium.org/958183002/diff/1/runtime/vm/profiler.cc
File runtime/vm/profiler.cc (right):

https://codereview.chromium.org/958183002/diff/1/runtime/vm/profiler.cc#newco...
runtime/vm/profiler.cc:1030: CopyStackBuffer(sample);
I would prefer to have the "if" here instead, and then ASSERT inside the static
helper functions, since this is part of the normal control flow rather than an
exceptional condition.

Powered by Google App Engine
This is Rietveld 408576698