Adjust handling of timers:

Adjust handling of timers:
- Every zero timer is enqueued individually in the event queue
  and handled in sequence with other events.
- Non-zero timers and zero timers expire in order. Therefor a
  due zero timer will also fire all preceding non-zero timers
  to ensure this order.

R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44095

[Ivan Posva, 2015-02-26 17:29:39]

iposva@google.com changed reviewers:
+ sgjesse@google.com, zra@google.com

[zra, 2015-02-26 19:04:35]

https://codereview.chromium.org/958123002/diff/1/runtime/lib/timer_impl.dart
File runtime/lib/timer_impl.dart (right):

https://codereview.chromium.org/958123002/diff/1/runtime/lib/timer_impl.dart#...
runtime/lib/timer_impl.dart:233: if (_firstZeroTimer == null) {
Code like the following 6 lines is repeated ~5 times. Maybe it would make sense
to make a function or class.

[Ivan Posva, 2015-02-27 11:47:42]

https://codereview.chromium.org/958123002/diff/1/runtime/lib/timer_impl.dart
File runtime/lib/timer_impl.dart (right):

https://codereview.chromium.org/958123002/diff/1/runtime/lib/timer_impl.dart#...
runtime/lib/timer_impl.dart:233: if (_firstZeroTimer == null) {
On 2015/02/26 19:04:35, zra wrote:
> Code like the following 6 lines is repeated ~5 times. Maybe it would make
sense
> to make a function or class.

Left the zero timer queueing alone, but as discussed the pending timers are
collected into a growable list.

[Søren Gjesse, 2015-02-27 12:38:46]

lgtm

https://codereview.chromium.org/958123002/diff/20001/runtime/lib/timer_impl.dart
File runtime/lib/timer_impl.dart (right):

https://codereview.chromium.org/958123002/diff/20001/runtime/lib/timer_impl.d...
runtime/lib/timer_impl.dart:371: // null.
Extend this comment to say that all zero timers stay in the list. So for zero
timers the timers where callback is null are not necessarily zero timers
canceled while processing timers.

[Søren Gjesse, 2015-02-27 14:12:56]

https://codereview.chromium.org/958123002/diff/20001/runtime/lib/timer_impl.dart
File runtime/lib/timer_impl.dart (right):

https://codereview.chromium.org/958123002/diff/20001/runtime/lib/timer_impl.d...
runtime/lib/timer_impl.dart:122: static const _TIMEOUT_EVENT = null;
Additional question: Why are you using 1 and null, instead of e.g. 0 and 1?

[Ivan Posva, 2015-02-27 16:45:30]

Committed patchset #2 (id:20001) manually as r44095 (presubmit successful).

[Ivan Posva, 2015-03-03 04:51:53]

https://codereview.chromium.org/958123002/diff/20001/runtime/lib/timer_impl.dart
File runtime/lib/timer_impl.dart (right):

https://codereview.chromium.org/958123002/diff/20001/runtime/lib/timer_impl.d...
runtime/lib/timer_impl.dart:122: static const _TIMEOUT_EVENT = null;
On 2015/02/27 14:12:56, Søren Gjesse wrote:
> Additional question: Why are you using 1 and null, instead of e.g. 0 and 1?

The external event handler is sending nulls for timeouts.

https://codereview.chromium.org/958123002/diff/20001/runtime/lib/timer_impl.d...
runtime/lib/timer_impl.dart:371: // null.
On 2015/02/27 12:38:46, Søren Gjesse wrote:
> Extend this comment to say that all zero timers stay in the list. So for zero
> timers the timers where callback is null are not necessarily zero timers
> canceled while processing timers.

Done.