Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1213)

Issue 957583002: Add a MultiChannel class. (Closed)

Created:
5 years, 10 months ago by nweiz
Modified:
5 years, 10 months ago
Reviewers:
Bob Nystrom, kevmoo
CC:
reviews_dartlang.org, kevmoo
Base URL:
git@github.com:dart-lang/unittest@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a MultiChannel class. This class multiplexes communication over a single underlying channel. It will be useful for communicating individually with test suites and tests over the server ↔ browser WebSocket connection. See #5 R=kevmoo@google.com Committed: https://github.com/dart-lang/unittest/commit/fb37c7a4098c4905ae104637748d45acbdef1159

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+553 lines, -0 lines) Patch
A lib/src/util/multi_channel.dart View 1 1 chunk +243 lines, -0 lines 0 comments Download
A test/multi_channel_test.dart View 1 chunk +310 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
nweiz
5 years, 10 months ago (2015-02-25 00:12:25 UTC) #1
nweiz
Sending this to Bob since Kevin is out.
5 years, 10 months ago (2015-02-25 22:26:31 UTC) #3
kevmoo
one nit, otherwise LGTM https://codereview.chromium.org/957583002/diff/1/lib/src/util/multi_channel.dart File lib/src/util/multi_channel.dart (right): https://codereview.chromium.org/957583002/diff/1/lib/src/util/multi_channel.dart#newcode50 lib/src/util/multi_channel.dart:50: /// This connects to the ...
5 years, 10 months ago (2015-02-25 23:43:31 UTC) #5
nweiz
Code review changes
5 years, 10 months ago (2015-02-26 00:15:58 UTC) #6
nweiz
https://codereview.chromium.org/957583002/diff/1/lib/src/util/multi_channel.dart File lib/src/util/multi_channel.dart (right): https://codereview.chromium.org/957583002/diff/1/lib/src/util/multi_channel.dart#newcode50 lib/src/util/multi_channel.dart:50: /// This connects to the remote [stream]. If this ...
5 years, 10 months ago (2015-02-26 00:16:09 UTC) #7
nweiz
5 years, 10 months ago (2015-02-26 00:16:17 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
fb37c7a4098c4905ae104637748d45acbdef1159 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698