Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 957483002: Verify acquired typed data: allow detection of use-after-free. (Closed)

Created:
5 years, 10 months ago by koda
Modified:
5 years, 9 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Verify acquired typed data: allow detection of use-after-free. With --verify_acquired_data, copy to a buffer on the side (which is zapped on release). Allows AddressSanitizer to catch bugs. Extend unit tests to exercise new code. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=44102

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -21 lines) Patch
M runtime/vm/dart_api_impl.cc View 1 2 3 4 5 5 chunks +61 lines, -17 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 7 chunks +53 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
koda
5 years, 10 months ago (2015-02-25 18:32:46 UTC) #1
koda
Note that this is still disabled by default, but my plan is to enable it ...
5 years, 10 months ago (2015-02-25 18:36:14 UTC) #2
siva
lgtm
5 years, 10 months ago (2015-02-25 23:41:38 UTC) #3
koda
5 years, 9 months ago (2015-02-27 19:24:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #6 (id:100001) manually as r44102 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698