Issue 957253002: Allow uri in deepJsonCompare

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 957253002: Allow uri in deepJsonCompare (Closed)

Created:
5 years, 10 months ago by ricow1

Modified:
5 years, 10 months ago

Reviewers:
Søren Gjesse, Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Allow uri in deepJsonCompare R=sgjesse@google.com, whesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44043

Patch Set 1 #

Total comments: 1

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/testing/dart/utils.dart	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ricow1

Committed patchset #1 (id:1) manually as 44043 (presubmit successful).

5 years, 10 months ago (2015-02-26 09:29:37 UTC) #3

Bill Hesse

5 years, 10 months ago (2015-02-26 09:31:11 UTC) #4

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/957253002/diff/1/tools/testing/dart/utils.dart
File tools/testing/dart/utils.dart (right):

https://codereview.chromium.org/957253002/diff/1/tools/testing/dart/utils.dar...
tools/testing/dart/utils.dart:273: if (a == null || a is num || a is String || a
is Uri) {
Please add bool as well, like in the hash builder in line 254.

Expand Messages | Collapse Messages