Issue 957193003: More changes to fix dependencies after github move

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 957193003: More changes to fix dependencies after github move (Closed)

Created:
5 years, 10 months ago by ricow1

Modified:
5 years, 10 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

More changes to fix dependencies after github move R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=44044

Patch Set 1 #

Total comments: 1

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -1 line)			Patch
M	dart/tools/addlatexhash.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	deps/dartium.deps/DEPS	View	2 chunks	+4 lines, -0 lines	1 comment	Download
M	deps/standalone.deps/DEPS	View	2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/957193003/diff/1/deps/dartium.deps/DEPS File deps/dartium.deps/DEPS (right): https://codereview.chromium.org/957193003/diff/1/deps/dartium.deps/DEPS#newcode21 deps/dartium.deps/DEPS:21: "collection_rev": "@1da9a07f32efa2ba0c391b289e2037391e31da0e", No use of this below.

5 years, 10 months ago (2015-02-26 10:09:47 UTC) #2

ricow1

5 years, 10 months ago (2015-02-26 10:12:23 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r44044 (presubmit successful).

Expand Messages | Collapse Messages