Chromium Code Reviews

Issue 956633004: pkg/unittest: move browser error above other skips (Closed)

Created:
5 years, 10 months ago by kevmoo
Modified:
5 years, 9 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/unittest.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+3 lines, -3 lines)
M .status View 2 chunks +3 lines, -3 lines 0 comments

Messages

Total messages: 6 (1 generated)
kevmoo
Trying to turn the bots green
5 years, 10 months ago (2015-02-24 22:39:02 UTC) #2
nweiz
I don't understand what this does. Regardless of whether the skip or the failure takes ...
5 years, 10 months ago (2015-02-24 23:31:58 UTC) #3
kevmoo
On 2015/02/24 23:31:58, nweiz wrote: > I don't understand what this does. Regardless of whether ...
5 years, 9 months ago (2015-03-03 18:17:40 UTC) #4
nweiz
lgtm
5 years, 9 months ago (2015-03-03 20:09:41 UTC) #5
kevmoo
5 years, 9 months ago (2015-03-03 20:11:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
230c987a19deb3c1938d6f7af545b72d44b0858a (presubmit successful).

Powered by Google App Engine