Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 956623006: Merge notifications computing into the 'notices' tag. (Closed)

Created:
5 years, 10 months ago by scheglov
Modified:
5 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Merge notifications computing into the 'notices' tag. Also cover incremental analysis with its own tag. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44013

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -83 lines) Patch
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 3 chunks +26 lines, -25 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 2 chunks +67 lines, -58 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
5 years, 10 months ago (2015-02-24 23:11:35 UTC) #1
Paul Berry
lgtm
5 years, 10 months ago (2015-02-24 23:26:54 UTC) #2
Brian Wilkerson
LGTM
5 years, 10 months ago (2015-02-24 23:39:52 UTC) #3
scheglov
5 years, 10 months ago (2015-02-25 01:42:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44013 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698