Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 956443003: Update project to match OSS template (Closed)

Created:
5 years, 10 months ago by Søren Gjesse
Modified:
5 years, 10 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/collection.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Added .gitignore and empty .status #

Patch Set 3 : http -> http #

Total comments: 2

Patch Set 4 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -3 lines) Patch
A .gitignore View 1 1 chunk +8 lines, -0 lines 0 comments Download
A .status View 1 1 chunk +4 lines, -0 lines 0 comments Download
A AUTHORS View 1 chunk +6 lines, -0 lines 0 comments Download
A CONTRIBUTING.md View 1 chunk +33 lines, -0 lines 0 comments Download
M LICENSE View 1 chunk +1 line, -1 line 0 comments Download
M README.md View 1 2 3 2 chunks +7 lines, -1 line 0 comments Download
A codereview.settings View 1 chunk +3 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
5 years, 10 months ago (2015-02-24 10:20:02 UTC) #1
ricow1
lgtm https://codereview.chromium.org/956443003/diff/40001/README.md File README.md (right): https://codereview.chromium.org/956443003/diff/40001/README.md#newcode75 README.md:75: [tracker]: https://github.com/dart-lang/sample/issues url
5 years, 10 months ago (2015-02-24 11:42:17 UTC) #2
Søren Gjesse
https://codereview.chromium.org/956443003/diff/40001/README.md File README.md (right): https://codereview.chromium.org/956443003/diff/40001/README.md#newcode75 README.md:75: [tracker]: https://github.com/dart-lang/sample/issues On 2015/02/24 11:42:17, ricow1 wrote: > url ...
5 years, 10 months ago (2015-02-24 12:11:30 UTC) #3
Søren Gjesse
5 years, 10 months ago (2015-02-24 12:11:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
683b9f57c9ede261bc394d6280a93ef1a51e140e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698